fix: add issuerURL for apple id (#2565) #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No issuer url was specified when using the Apple ID provider, this forced usersers to manually enter it in the provider config. This PR adds the Apple ID issuer url to the provider simplifying the setup.
harnash
approved these changes
Oct 21, 2022
Codecov Report
@@ Coverage Diff @@
## fandom_master #83 +/- ##
================================================
Coverage ? 74.55%
================================================
Files ? 323
Lines ? 18624
Branches ? 0
================================================
Hits ? 13886
Misses ? 3739
Partials ? 999 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Description
No issuer url was specified when using the Apple ID provider, this forced usersers to manually enter it in the provider config.
Who might be interested?
@Wikia/platform-team