-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DELETE request drops the body #352
Comments
I see your point. |
I've added a Please test MyGet version: |
@AlexGhiondea ; did you have time to test? |
@AlexGhiondea ; did you have time to test this preview version? |
Hey Thanks for adding that! I will give it a try later today!! Thanks, |
@AlexGhiondea Did you have time to test this? |
@AlexGhiondea Can you please test and report your findings? |
@StefH I didn’t get around to test this yet. I will give it a try at lunch today! |
@StefH I wasn't able to get the package from the feed, so I cloned and built locally your PR. With that, the tests that require a body for a DELETE operation work if you specify that setting! Thanks for making the change! I will update my version once you release!! |
Thank you for testing this. I will merge this PR to master, keep a watch on the official NuGet packages. |
It looks like for a DELETE request the body is not parsed.
I looked at the history but couldn't figure out if there was a reason why for a DELETE the body is not parsed/matched?
I am writing tests that depend on the DELETE request sending a body and this makes it tricky to test.
The fix can be as easy as flipping this to
true
, however I am not sure what the side effects could be.https://github.com/WireMock-Net/WireMock.Net/blob/master/src/WireMock.Net/Util/BodyParser.cs#L36
The text was updated successfully, but these errors were encountered: