Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithProxy(...) also use all proxy settings #550

Merged
merged 8 commits into from
Dec 8, 2020
Merged

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Dec 6, 2020

No description provided.

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #550 (5493811) into master (04d55b0) will increase coverage by 0.64%.
The diff coverage is 89.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
+ Coverage   75.55%   76.20%   +0.64%     
==========================================
  Files         139      142       +3     
  Lines        5563     5597      +34     
  Branches      562      565       +3     
==========================================
+ Hits         4203     4265      +62     
+ Misses       1192     1163      -29     
- Partials      168      169       +1     
Impacted Files Coverage Δ
src/WireMock.Net/Owin/WireMockMiddleware.cs 91.97% <83.33%> (-0.83%) ⬇️
...c/WireMock.Net/Serialization/MappingToFileSaver.cs 83.33% <83.33%> (ø)
src/WireMock.Net/Server/WireMockServer.Admin.cs 55.97% <83.33%> (-2.27%) ⬇️
src/WireMock.Net/Proxy/ProxyHelper.cs 87.71% <87.71%> (ø)
src/WireMock.Net/Http/HttpClientBuilder.cs 68.96% <100.00%> (ø)
src/WireMock.Net/Mapping.cs 96.15% <100.00%> (+0.80%) ⬆️
...ireMock.Net/ResponseBuilders/Response.WithProxy.cs 100.00% <100.00%> (+5.55%) ⬆️
src/WireMock.Net/ResponseBuilders/Response.cs 94.97% <100.00%> (+0.02%) ⬆️
...ck.Net/Serialization/JsonSerializationConstants.cs 100.00% <100.00%> (ø)
src/WireMock.Net/Serialization/MappingConverter.cs 69.46% <100.00%> (+14.97%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d55b0...5493811. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.2% 89.2% Coverage
0.0% 0.0% Duplication

@StefH StefH merged commit 35565f6 into master Dec 8, 2020
@StefH StefH deleted the proxy_also_for_WithProxy branch December 8, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant