Fix bugs when reading big-endian u64 SAS catalog files #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs when reading big-endian u64 SAS catalog files.
In some cases ReadStat is currently checking a single byte for a value which is actually stored as a 16 bit int, which works fine on little-endian files but returns 0 when a file is big-endian.
The other changes just change the integer size being read from the file - it was incorrect in a few spots but only causes an issue when it's a big-endian file.
From tidyverse/haven#696 - example catalog files at haven_reprex_github.zip. This zip contains the same format file produced by multiple versions of SAS, so I've been working off direct comparisons between the two files.
Thanks!