Implement a handler for file header #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file version, compression, writer version, etc. Before, this information was impossible to extract from the library.
|
Looks like the AppVeyor build is broken but it seems unrelated to my changes. I would appreciate if a maintainer could take a look. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows clients to learn the file version, compression, writer version, etc. Before, this information was impossible to extract from the library.
This is really useful to inform end users ahead of time whether given file is supported or not, and if not - why (for example because lack of support for ASCII mode or version 1 files in librdata).
The change is backwards compatible because the newly added handler
header_handleris optional and in older code it will simply not be called.