Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the interactive code block plugin #1652

Closed
wants to merge 1 commit into from

Conversation

jonathanbossenger
Copy link
Collaborator

This PR adds the interactive code block plugin to Learn WordPress, which enables running PHP code directly in the browser thanks to WordPress Playground.

https://wordpress.org/plugins/interactive-code-block/

While this plugin is still largely experimental, the idea of this PR is to get the base plugin installed, so that when future updates are rolled out, we can get them more quickly.

@jonathanbossenger
Copy link
Collaborator Author

@adamwoodnz I'm not sure if this code needs to be reviewed separately other than the review that would have taken place getting it approved for the plugin repo?

@jonathanbossenger jonathanbossenger added the [Dev] Needs Testing Website development issues needing testing. label Jun 29, 2023
@sumitsinghwp
Copy link

I will test this PR and let you know @jonathanbossenger

@alexstine
Copy link
Contributor

This also needs accessibility testing. The WP Playground is largely a mess ATM. Another example of how we failed to check before promoting and making Playground live. I'll try to have a look soon.

Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to add this to source? We don't usually; Sensei Pro is an exception because it's a paid plugin.

We can install this in prod at any time if it meets our requirements. I imagine plugin review is probably sufficient in terms of code, however it sounds like there are accessibility concerns.

For local dev I think it should be added to the list of plugins in composer.json require-dev.

@jonathanbossenger
Copy link
Collaborator Author

Is there a reason to add this to source? We don't usually; Sensei Pro is an exception because it's a paid plugin.

We can install this in prod at any time if it meets our requirements. I imagine plugin review is probably sufficient in terms of code, however it sounds like there are accessibility concerns.

For local dev I think it should be added to the list of plugins in composer.json require-dev.

Honestly, I wasn't aware it was possible to add additional plugins specifically to Learn any other way 😁

@jonathanbossenger
Copy link
Collaborator Author

I'm going to close this PR for now, we can always revisit this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Fix or enhancement related to accessibility. [Dev] Needs Testing Website development issues needing testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants