Workshops: Move layout elements from post_content to theme.
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
added
[Type] Enhancement
Having them in `post_content` means that we have to manually update all existing posts every time we change the layout.
iandunn
force-pushed
the
workshop-template-reduction
branch
from
253f8f4
to
b1e8102
Compare
coreymckrill
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
👍 Looks good, and doesn't seem to break anything. A few comments below.
Also, I wonder if while we're at this, we should just get rid of the 'template_lock' => 'all' property of the workshop CPT entirely. I think we set it originally to make sure that the stuff in the sidebar didn't get accidentally deleted, and now that the sidebar is hard-coded, it seems like more of a hinderance than anything else.
Comment on lines
+17
to
+22
| <textarea | ||
| id="workshop-video-url" | ||
| name="video-url" | ||
| class="large-text" | ||
| rows="4" | ||
| ><?php echo esc_url( $post->video_url ); ?></textarea> |
There was a problem hiding this comment.
Why a textarea instead of just a text input?
There was a problem hiding this comment.
There's never enough room to display the full URL in a text input, even with the .large-text class
wp-content/themes/pub/wporg-learn-2020/single-wporg_workshop.php
Outdated
Show resolved
Hide resolved
|
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having them in
post_contentmeans that we have to manually update all existing posts every time we change the layout.See #195, https://wordpress.slack.com/archives/C01KC5VDQBC/p1616436392000400
Closes #201
Blocker for #200