WP/EnqueuedResources: various tweaks #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. to safeguard these are handled correctly. Note: these are in a separate file for maintainability as any code which would be placed _after_ the flexible heredoc/nowdoc would not be tokenized correctly on PHP < 7.3, making the tests maintainer error prone if the tests were in the same file.
Always retrieve the stack pointer to the last token of a potentially multi-line text string and skip to the end after analyzing the content. While the `TextStrings::getEndOfCompleteTextString()` and the `TextStrings::getCompleteTextString()` have some overlap, the results of the overlapping code is cached, so this should barely affect performance, while skipping to the end of the text string will greatly improve performance for files containing long multi-line text strings.
dingo-d
approved these changes
Dec 22, 2022
GaryJones
deleted the
feature/enqueuedresources-phpcsutils-and-modern-php
branch
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WP/EnqueuedResources: add tests with PHP 7.3+ flexible heredoc/nowdocs
.. to safeguard these are handled correctly.
Note: these are in a separate file for maintainability as any code which would be placed after the flexible heredoc/nowdoc would not be tokenized correctly on PHP < 7.3, making the tests maintainance error prone if the tests were in the same file.
WP/EnqueuedResources: minor code performance tweak
Always retrieve the stack pointer to the last token of a potentially multi-line text string and skip to the end after analyzing the content.
While the
TextStrings::getEndOfCompleteTextString()and theTextStrings::getCompleteTextString()have some overlap, the results of the overlapping code is cached, so this should barely affect performance, while skipping to the end of the text string will greatly improve performance for files containing long multi-line text strings.WP/EnqueuedResources: minor message tweak for clarity