Move is_in_function_call() utility method to dedicated ContextHelper
#2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `is_in_function_call()` utility method is only used by a small set of sniffs, so is better placed in a dedicated class. This commit moves the `is_in_function_call()` method to the new `WordPressCS\WordPress\Helpers\ContextHelper` class and starts using that class in the relevant sniffs. Includes adding a type declaration for the `$valid_functions` parameter. Related to 1465 This method will be tested via the `WordPress.Security.NonceVerification` sniff (via pre-existing and a few new tests).
dingo-d
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
is_in_function_call()utility method is only used by a small set of sniffs, so is better placed in a dedicated class.This commit moves the
is_in_function_call()method to the newWordPressCS\WordPress\Helpers\ContextHelperclass and starts using that class in the relevant sniffs.Includes adding a type declaration for the
$valid_functionsparameter.Related to #1465
This method will be tested via the
WordPress.Security.NonceVerificationsniff (via pre-existing and a few new tests).