Move sanitization functions related functionality to dedicated SanitizingFunctionsTrait
#2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izationFunctionsTrait` The sanitization function lists are only used by a small set of sniffs, so are better placed in a dedicated trait. The choice for a `trait` over a `class` is due to the `public` properties allowing for adding additional functions to the lists. Moving both the base function lists + the `public` properties to the same trait will allow us to encapsulate all the functionality related to the use of these lists in one place. The `$sanitizingFunctions` and the `$unslashingSanitizingFunctions` property, containing the base lists, have also been made `private`. Checking whether or not something is a sanitization function should now be done by calling the `SanitizationFunctionsTrait::is_sanitization_function()` or the `SanitizationFunctionsTrait::is_sanitization_and_unslashing_function()` method. Related to 1465
GaryJones
reviewed
Jun 20, 2023
dingo-d
approved these changes
Jun 23, 2023
jrfnl
changed the title
SanitizationFunctionsTraitSanitizingFunctionsTrait
|
Hmm.. I force-pushed the branch and the branch (correctly) says there is now one commit, but this PR still shows as if there were 3 commits... ? Did I just break GH ?
|
|
Yeah, I can see 3 commits. I don't see a force push commit though 🤷🏼♂️ |
|
As this PR doesn't seem to want to update, shall we do Squash commit in the PR itself ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sanitization function lists are only used by a small set of sniffs, so are better placed in a dedicated trait.
The choice for a
traitover aclassis due to thepublicproperties allowing for adding additional functions to the lists.Moving both the base function lists + the
publicproperties to the same trait will allow us to encapsulate all the functionality related to the use of these lists in one place.The
$sanitizingFunctionsand the$unslashingSanitizingFunctionsproperty, containing the base lists, have also been madeprivate.Checking whether or not something is a sanitization function should now be done by calling the
SanitizingFunctionsTrait::is_sanitizing_function()or theSanitizingFunctionsTrait::is_sanitizing_and_unslashing_function()method.Related to #1465