Docs: array properties expect arrays #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on 1584, which was included in WPCS 2.0.0. While PHPCS still supports the _old_ array syntax (comma-delimited string), WPCS no longer has a (WPCS native) tolerance for those properties being passed with the `type="array"` attribute, so these public properties should always be arrays.
jrfnl
force-pushed
the
feature/docs-public-array-properties
branch
from
0649adf
to
f119d86
Compare
dingo-d
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1584, which was included in WPCS 2.0.0.
While PHPCS still supports the old array syntax (comma-delimited string), WPCS no longer has a (WPCS native) tolerance for those properties being passed with the
type="array"attribute, so these public properties should always be arrays.