Skip to content

Commit

Permalink
Improve image quality
Browse files Browse the repository at this point in the history
  • Loading branch information
youknowriad committed Oct 17, 2023
1 parent b5f408f commit 115cacd
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 11 deletions.
4 changes: 2 additions & 2 deletions packages/edit-site/src/components/dataviews/view-grid.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function ViewGrid( { data, fields, view, actions } ) {
<VStack key={ index }>
<div className="dataviews-view-grid__media">
{ ( mediaField &&
mediaField.render( { item } ) ) || (
mediaField.render( { item, view } ) ) || (
<Placeholder
withIllustration
style={ {
Expand All @@ -47,7 +47,7 @@ export function ViewGrid( { data, fields, view, actions } ) {
{ visibleFields.map( ( field ) => (
<div key={ field.id }>
{ field.render
? field.render( { item } )
? field.render( { item, view } )
: field.accessorFn( item ) }
</div>
) ) }
Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/dataviews/view-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ function ViewList( {
delete column.render;
column.cell = ( props ) => {
return field.render
? field.render( { item: props.row.original } )
? field.render( { item: props.row.original, view } )
: field.accessorFn( props.row.original );
};
return column;
Expand Down
10 changes: 4 additions & 6 deletions packages/edit-site/src/components/media/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,12 @@
*/
import { useEntityRecord } from '@wordpress/core-data';

function Media( { id, size, ...props } ) {
function Media( { id, size = [ 'large', 'medium', 'thumbnail' ], ...props } ) {
const { record: media } = useEntityRecord( 'root', 'media', id );
const sizesPerPriority = [ 'large', 'thumbnail' ];
const currentSize =
size ??
sizesPerPriority.find( ( s ) => !! media?.media_details?.sizes[ s ] );
const currentSize = size.find(
( s ) => !! media?.media_details?.sizes[ s ]
);
const mediaDetails = media?.media_details?.sizes[ currentSize ];

if ( ! mediaDetails ) {
return null;
}
Expand Down
8 changes: 6 additions & 2 deletions packages/edit-site/src/components/page-pages/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,16 @@ export default function PagePages() {
id: 'featured-image',
header: __( 'Featured Image' ),
accessorFn: ( page ) => page.featured_media,
render: ( { item } ) =>
render: ( { item, view: currentView } ) =>
!! item.featured_media ? (
<Media
className="edit-site-page-pages__featured-image"
id={ item.featured_media }
size="thumbnail"
size={
currentView.type === 'list'
? [ 'thumbnail', 'medium', 'large', 'full' ]
: [ 'large', 'medium', 'full', 'thumbnail' ]
}
/>
) : null,
enableSorting: false,
Expand Down

0 comments on commit 115cacd

Please sign in to comment.