Avoid creating font families without font faces. (#59436)

If we ae trying to create a new font family with font faces but the font family was created in the database but the font faces failed because of the file system permissions, the font family is removed from the database. --- Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: mikachan <[email protected]>
WordPress · Feb 28, 2024 · ab2123d · ab2123d
1 parent df5dc24
commit ab2123d
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/packages/edit-site/src/components/global-styles/font-library-modal/context.js b/packages/edit-site/src/components/global-styles/font-library-modal/context.js
@@ -202,6 +202,7 @@ function FontLibraryProvider( { children } ) {
 
 	async function installFont( fontFamilyToInstall ) {
 		setIsInstalling( true );
+		let isANewFontFamily = false;
 		try {
 			// Get the font family if it already exists.
 			let installedFontFamily = await fetchGetFontFamilyBySlug(
@@ -210,6 +211,7 @@ function FontLibraryProvider( { children } ) {
 
 			// Otherwise create it.
 			if ( ! installedFontFamily ) {
+				isANewFontFamily = true;
 				// Prepare font family form data to install.
 				installedFontFamily = await fetchInstallFontFamily(
 					makeFontFamilyFormData( fontFamilyToInstall )
@@ -268,6 +270,11 @@ function FontLibraryProvider( { children } ) {
 				sucessfullyInstalledFontFaces.length === 0 &&
 				alreadyInstalledFontFaces.length === 0
 			) {
+				if ( isANewFontFamily ) {
+					// If the font family is new, delete it to avoid having font families without font faces.
+					await fetchUninstallFontFamily( installedFontFamily.id );
+				}
+
 				throw new Error(
 					sprintf(
 						/* translators: %s: Specific error message returned from server. */