Embed Block: handle click events

[mtias]

Should we catch all click events occuring within the iframe/embed content and disable them in the editor context? That could be an easy way of not needing an overlay but preventing video from playing, tweets from navigating away, etc.

[aduth]

Not easily: https://stackoverflow.com/questions/2381336/detect-click-into-iframe-using-javascript

[mtias]

Right, the implementation can still be through an overlay, just not a visible one.

[westonruter]

Using pointer-events:none with tabindex=-1 seems to work without having to add an overlay: https://jsfiddle.net/westonruter/11279unb/

[ellatrix]

@westonruter Nice! Do you need the tabIndex? Seems to work fine here without.

[westonruter]

@iseulde yes, the tabIndex is needed as otherwise you can tab into the iframe window.

[ellatrix]

That's okay, right?

[westonruter]

I thought the goal was to prevent a user from interacting with an iframe? If they can tab inside of an iframe, then this wouldn't happen:

preventing video from playing, tweets from navigating away, etc.

[ellatrix]

Well, we'd prevent it as long as the block is not selected. If the block is selected, they can interact with it? (Same as core now.) So we take pointer-events: none away for .is-selected. Tabbing wouldn't matter for this.

[ellatrix]

@westonruter Like this? 79495e0

[westonruter]

OK, I didn't realize that the iframe should be able to be interacted with if the block is selected.

[jasmussen]

Just cross referencing this with #483

[mtias]

Let's just keep one. Closing in favor of #483.