Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block pointer events and focus in embedded content #1114

Closed
wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

Fixes #1002. Props @westonruter.

Testing: make sure no embedded content can be tabbed into or clicked.

@ellatrix ellatrix self-assigned this Jun 10, 2017
@notnownikki
Copy link
Member

👍

Solves the problem of accidentally playing videos when setting captions on youtube embeds, too. Nice!

@ellatrix
Copy link
Member Author

Hm, the tabIndex doesn't work. Turns out you have to add that to all focusable descendants... I'm not sure how to proceed as there seems to be no way to prevent tabbing inside the embed.

@ellatrix
Copy link
Member Author

Closing for the above reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants