Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wording for the color picker saturation #13444

Closed
afercia opened this issue Jan 23, 2019 · 1 comment
Closed

Fix wording for the color picker saturation #13444

afercia opened this issue Jan 23, 2019 · 1 comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jan 23, 2019

In the color picker, there's a visually hidden descriptive text that says:

Use your arrow keys to change the base color. Move up to lighten the color, down to darken, left to increase saturation, and right to decrease saturation.

gutenberg/packages/components/src/color-picker/saturation.js

Lines 177 to 179 in 0f58915

{ __(
'Use your arrow keys to change the base color. Move up to lighten the color, down to darken, left to increase saturation, and right to decrease saturation.'
) }

Hosever, left decreases saturation, while right increases it. The text should be amended accordingly.

screenshot 2019-01-23 at 17 56 19
@afercia afercia added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Jan 23, 2019
@dixitadusara dixitadusara mentioned this issue Jan 24, 2019
Merged
@jorgefilipecosta
Copy link
Member

Fixed in: #13479

jorgefilipecosta pushed a commit that referenced this issue Jan 30, 2019
@dixitadusara @jorgefilipecosta
Fixed wording for the color picker saturation (#13479)
f2c5db6 
Related: #13444 

This pull request seeks to fix wording for the color picker saturation.

Let me know if any changes require.

Thank you,
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@dixitadusara @youknowriad
Fixed wording for the color picker saturation (#13479)
ec3c9c8 
Related: #13444 

This pull request seeks to fix wording for the color picker saturation.

Let me know if any changes require.

Thank you,
youknowriad pushed a commit that referenced this issue Mar 6, 2019
@dixitadusara @youknowriad
Fixed wording for the color picker saturation (#13479)
7421910 
Related: #13444 

This pull request seeks to fix wording for the color picker saturation.

Let me know if any changes require.

Thank you,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afercia @jorgefilipecosta