Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Block: Custom HTML #1386

Closed
jasmussen opened this issue Jun 23, 2017 · 4 comments
Closed

Add Block: Custom HTML #1386

jasmussen opened this issue Jun 23, 2017 · 4 comments
Labels
[Feature] Blocks Overall functionality of blocks
Milestone

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Jun 23, 2017

Let's build a block that allows you to paste custom HTML into it.

This mockup includes a new pattern: Text button groups. It's exactly the same as the control group containing alignments, in that you can only pick one button at a time in the group. But this one has text instead of icons inside.

Attributes

  • Code & Preview tabs

Clicking the preview tab shows a preview of the form instead of the HTML.

Syntax highlighting and line numbers is a "nice to have", and doesn't need to be in this block in V1.

States

Neutral:

custom html

Selected:

custom html selected

@jasmussen jasmussen added the [Feature] Blocks Overall functionality of blocks label Jun 23, 2017
@mtias mtias added this to the Beta 2 milestone Jun 23, 2017
@StaggerLeee
Copy link

StaggerLeee commented Jun 24, 2017

HI, What are You using to get code coloring (and line numbers) ? I have latest Gutenberg and cannot see it.

OK, sorry...missed that "Mockup". Have seen it on some other issue too.

@jasmussen
Copy link
Contributor Author

OK, sorry...missed that "Mockup". Have seen it on some other issue too.

Right was about to say ;) syntax highlighting hasn't been implemented yet. But it would be really cool to have.

@StaggerLeee
Copy link

Do You (miss)use Amphetamines ? Or is Matt Mullenweg paying you well.

Anything people ask here you make for few days. You ask something smaller in Pods community, expect it be finished for 2 years.

Have never seen such activity and enthusiasm in anything connected to WordPress before.

@sc0ttkclark
Copy link

Just noticed you mentioned Pods again here, wanted to again reiterate that isn't true and does not accurately reflect the circumstance/context of that occasion (a very complicated feature). I'll leave it at that.

noisysocks added a commit that referenced this issue Jan 10, 2018
Make the CodeEditor in the HTML block look vaguely like what Joen mocked
up in #1386.
noisysocks added a commit that referenced this issue Jan 18, 2018
Make the CodeEditor in the HTML block look vaguely like what Joen mocked
up in #1386.
noisysocks added a commit that referenced this issue Jan 29, 2018
Make the CodeEditor in the HTML block look vaguely like what Joen mocked
up in #1386.
noisysocks added a commit that referenced this issue Feb 2, 2018
Make the CodeEditor in the HTML block look vaguely like what Joen mocked
up in #1386.
noisysocks added a commit that referenced this issue Feb 5, 2018
Make the CodeEditor in the HTML block look vaguely like what Joen mocked
up in #1386.
noisysocks added a commit that referenced this issue Feb 8, 2018
Make the CodeEditor in the HTML block look vaguely like what Joen mocked
up in #1386.
noisysocks added a commit that referenced this issue Feb 26, 2018
Make the CodeEditor in the HTML block look vaguely like what Joen mocked
up in #1386.
noisysocks added a commit that referenced this issue Feb 27, 2018
Make the CodeEditor in the HTML block look vaguely like what Joen mocked
up in #1386.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

No branches or pull requests

4 participants