Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why shortcode block outputs as oneline textarea in 5.5.0? #15032

Closed
hustlahusky opened this issue Apr 18, 2019 · 8 comments · Fixed by #15365
Closed

Why shortcode block outputs as oneline textarea in 5.5.0? #15032

hustlahusky opened this issue Apr 18, 2019 · 8 comments · Fixed by #15365
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@hustlahusky
Copy link

Describe the bug
I've just updated to 5.5.0 and find out that all my shortcodes blocks looks like one-line textareas. I use shortcodes to wrap large amount of content, for example, to add fragments of code in my blog posts. And now it looks like this: https://imgur.com/2JzvARD.jpg . Also even my small shortcodes now not fully showed in one-line textarea: https://imgur.com/eTAxm2t.jpg
It just looks terrible and frustrates me. Right now I just forced to downgrading to old version of plugin.

Expected behavior
It must shows all my content inside textarea. At least you can simply fix this with expanding textarea while it filled with content

Additional context

@bobbingwide
Copy link
Contributor

Oh my! It's atrocious.
core-shortcode-block-gutenberg-5 5-youre-joking

@bobbingwide
Copy link
Contributor

bobbingwide commented Apr 22, 2019

Let me specify my basic requirements for how it might appear.

  • The shortcode block is basically a textarea where I can write shortcodes.
  • But, unlike a paragraph block, I don't expect any HTML to be generated other than that created by the shortcode.
  • Some shortcodes have many parameters so may be very long.
  • Some shortcodes handle content between the start and end tags. These could also be very long.
  • The textarea should therefore be expanded to fill the space available.
  • As a sighted person the label is an unnecessary distraction.
  • The custom HTML block (core/html) does not have a label.
  • Nor does the preformatted block ( core/preformatted ).

@bobbingwide
Copy link
Contributor

Here's an example showing a modified Shortcode block and Custom HTML and Preformatted blocks for comparison.
image

@aduth
Copy link
Member

aduth commented Apr 23, 2019

Possible regression of #14719 (cc @mapk)

@aduth aduth added the [Type] Regression Related to a regression in the latest release label Apr 23, 2019
@bobbingwide
Copy link
Contributor

It appears that it was this commit that messed it up. aaa9e3a

@mapk
Copy link
Contributor

mapk commented Apr 30, 2019

Sorry folks. The field should expand with the text, or at least be expandable by dragging the corner. I'll try to get a PR going to solve this asap.

mapk added a commit that referenced this issue May 20, 2019
* Fixes #15032. Allows field to expand with text.

* Added a max-height on this.
@hustlahusky
Copy link
Author

Nice to see that fix was implemented. But how soon it will be available in plugin?

@aduth
Copy link
Member

aduth commented May 28, 2019

@hustlahusky It should be available as of the Gutenberg 5.8 plugin release, scheduled for tomorrow (Wednesday, May 28).

For future reference, if you look to the pull request, it should typically be assigned into a release milestone, visible in the right sidebar.

See #15365

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants