Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation block: Add default block stylesheet #17542

Closed
noisysocks opened this issue Sep 24, 2019 · 5 comments
Closed

Navigation block: Add default block stylesheet #17542

noisysocks opened this issue Sep 24, 2019 · 5 comments
Labels
[Block] Navigation Affects the Navigation Block Needs Design Needs design efforts. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@noisysocks
Copy link
Member

Screen Shot 2019-09-24 at 12 11 54

  • Add a block stylesheet that styles the Navigation block to look similar to how it looks in the editor.
  • Allow for themes to override these styles and do the heavy lifting using their own stylesheets.
@noisysocks noisysocks added [Type] Task Issues or PRs that have been broken down into an individual action to take [Block] Navigation Affects the Navigation Block labels Sep 24, 2019
@noisysocks noisysocks mentioned this issue Sep 24, 2019
Closed
12 tasks
@noisysocks
Copy link
Member Author

Anything we do here has to take into account that colours will be customisable as per #16830.

@draganescu draganescu added Needs Design Needs design efforts. Needs Design Feedback Needs general design feedback. labels Sep 27, 2019
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Sep 30, 2019
@karmatosed
Copy link
Member

Just flagging this as needs design then we can get feedback after.

@karmatosed karmatosed self-assigned this Sep 30, 2019
@draganescu draganescu mentioned this issue Oct 2, 2019
Merged
9 tasks
@obenland
Copy link
Member

We could start with a default style from one of the default themes, or something like _s, for structure, and give still give themes the power over fonts, colors, sizes, etc

@shaunandrews Any thoughts here?

@obenland obenland changed the title Navigation block: Add default block stylesheet (3P) Navigation block: Add default block stylesheet Oct 21, 2019
@obenland obenland changed the title (3P) Navigation block: Add default block stylesheet Navigation block: Add default block stylesheet Oct 21, 2019
@karmatosed karmatosed removed their assignment Oct 21, 2019
@karmatosed
Copy link
Member

I think a default theme style is ace. Removing myself as this feels like a solution we can 'just do'.

@frontdevde frontdevde mentioned this issue Oct 24, 2019
Merged
7 tasks
@obenland
Copy link
Member

obenland commented Nov 4, 2019

Fixed in #18094.

@obenland obenland closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block Needs Design Needs design efforts. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@draganescu @karmatosed @noisysocks @obenland