Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Columns: Insert button in the Column block overlaps the block toolbar #17993

Closed
gziolo opened this issue Oct 17, 2019 · 9 comments
Closed
Labels
[Block] Columns Affects the Columns Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Mobile Web Viewport sizes for mobile and tablet devices Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended

Comments

@gziolo
Copy link
Member

gziolo commented Oct 17, 2019

Describe the bug
The insert button in the Column block overlaps the block toolbar on small screens.

To reproduce
Steps to reproduce the behavior:

  1. Change the browser width to enable small viewport.
  2. Add a new post.
  3. Insert any block.
  4. Insert Columns block.
  5. Select the previous block.
  6. Observer how the insert button in the Column block overlaps the block toolbar.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Screen Shot 2019-10-10 at 17 19 17

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Chrome
  • Version: 77.0.3865.120
@gziolo gziolo added [Type] Bug An existing feature does not function as intended Mobile Web Viewport sizes for mobile and tablet devices [Block] Columns Affects the Columns Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Oct 17, 2019
@jasmussen
Copy link
Contributor

I can't reproduce.

mobile

I'm noticing a ton of other mobile bugs that are bad, but not this specific one. Can you give additional steps to reproduce?

@gziolo
Copy link
Member Author

gziolo commented Oct 18, 2019

I guess you are testing with Safari on the simulator. I was testing with Chrome and small viewport:

Screen Shot 2019-10-18 at 14 59 50

@jasmussen
Copy link
Contributor

No this was chrome in the inspector. Could be Safari related then?

@gziolo
Copy link
Member Author

gziolo commented Oct 18, 2019

Safari:

Screen Shot 2019-10-18 at 15 08 08

Columns block, 2 columns 50/50. I use arrow keys (down/up) to navigate.

I think you need to have 50/50 to make each of them fill all the space in one row.

@edmundcwm
Copy link
Contributor

Hello all,

First-timer here. I managed to replicate the issue. Anyone looking into this currently? If not i will try.

@gziolo
Copy link
Member Author

gziolo commented Dec 3, 2019

@edmundcwm, go for it, thanks 🙇

@jasmussen
Copy link
Contributor

Worth noting that this PR, #18686, will make the toolbar docked to the top on mobile breakpoints, which should obviate the need for this to be fixed. So maybe it isn't worth it?

@gziolo
Copy link
Member Author

gziolo commented Dec 9, 2019

@jasmussen can we close it now that you landed PR which changes how the toolbar works?

@jasmussen
Copy link
Contributor

We can, yes!

Screenshot 2019-12-10 at 10 39 35

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Mobile Web Viewport sizes for mobile and tablet devices Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants