Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heading hierarchy in the sidebar #2024

Closed
afercia opened this issue Jul 26, 2017 · 1 comment · Fixed by #3937
Closed

Heading hierarchy in the sidebar #2024

afercia opened this issue Jul 26, 2017 · 1 comment · Fixed by #3937
Assignees
@jasmussen
Labels
[Feature] Document Settings Document settings experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@afercia
Copy link
Contributor

afercia commented Jul 26, 2017

Noticed while checking #2020. See also #503.

The whole heading hierarchy in Gutenberg is still to address, there should be a main h1 to indicate the page purpose, then the main sections should have h2 headings, and so on. Heading levels should not be skipped.

In the sidebar, currently the settings sections use an h3, They should probably be changed, depending also on the other headings to add in the page.

Current hierarchy:

screen shot 2017-07-26 at 14 48 04

Many of the headings in the screenshot above are actually in the demo post content. The "All that you can embed!" one is the last heading block in the content.

"Gallery Settings" and "Block Settings" are actually in the sidebar, but given this structure they're identified as children of "All that you can embed!" 🙁
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 26, 2017
@afercia
Copy link
Contributor Author

afercia commented Aug 3, 2017

See also #503

@mtias mtias added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Feature] Document Settings Document settings experience labels Nov 20, 2017
@jasmussen jasmussen self-assigned this Dec 5, 2017
@jasmussen jasmussen mentioned this issue Dec 8, 2017
Merged
jasmussen pushed a commit that referenced this issue Dec 12, 2017
Add editor heading for screenreaders
b5d73e5 
This is round 2 of #3801.

It mitigates/fixes #503 and fixes #2024.

What remains to be done in this branch is:

- Make sure the text is translatable, right now it's hardcoded to "Edit Post"
- Make sure the text is contextual (so it shows Edit Page, Edit CPT etc)
@jasmussen jasmussen mentioned this issue Dec 12, 2017
Merged
3 tasks
Tug pushed a commit that referenced this issue Mar 19, 2020
@hypest
Merge pull request #2024 from wordpress-mobile/issue/1697-improve-tak…
58039bd 
…e-video-icon

Update Gutenberg ref to use video-alt2 icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
[Feature] Document Settings Document settings experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add editor heading for screenreaders WordPress/gutenberg
3 participants
@mtias @jasmussen @afercia