Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote and pullquote blocks: consider to use a cite element for the citation instead of a footer #2647

Closed
afercia opened this issue Sep 2, 2017 · 1 comment
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time

Comments

@afercia
Copy link
Contributor

afercia commented Sep 2, 2017

While the HTML 5.1 recommendation states that <blockquote> elements can have an optional citation "which must be within a footer or cite element", all the examples in the recommendation always use a <cite> element, whether it's wrapped in a footer or not. The only exceptions seems to be the "permalink" example. See https://www.w3.org/TR/html51/grouping-content.html#the-blockquote-element

Seems to me the footer element is more suited for generic information about its section, while the cite element is more specific to a quote.

For better semantics, I'd propose to simplify and just use a <cite> element.

Aside: when the nearest ancestor of a <footer> element is the body, then the footer is also a landmark region. This is not the case in Gutenberg (and if it will be removed, it won't for sure) so there should be no concerns. Worth noting Firefox incorrectly reports all footer elements as landmarks whether they're in the scope of the body or not, but that's going to be fixed in Firefox 57, see: https://www.marcozehe.de/2017/08/30/firefox-57-will-less-chatty-screen-readers-situations/

In the screenshot below: footers in the demo content reported as landmarks in Firefox 55.0.3 (will be fixed in FF 57)

screenshot 55

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Sep 2, 2017
tfrommen added a commit to tfrommen/gutenberg that referenced this issue Oct 2, 2017
tfrommen added a commit to tfrommen/gutenberg that referenced this issue Oct 4, 2017
@afercia afercia added the [Feature] Blocks Overall functionality of blocks label Oct 19, 2017
@mtias
Copy link
Member

mtias commented Dec 7, 2017

Done in #3665.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time
Projects
None yet
Development

No branches or pull requests

3 participants