-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot add pattern within a block #31342
Comments
Hey 👋 - many blocks that have inner blocks (like Cover) can insert a pattern inside. In the gif below you can see that this is possible. One thing worths noting though is that there is a (not in depth) check that checks if pattern's blocks are allowed based on where they are going to be inserted. For example if we have in our settings/preferences some blocks that are not allowed, the patterns that include those blocks are not shown as an option. Could be that the case of the issue you're having? |
Hey. Is there a setting that needs to be added to registered patterns to
allow them to appear as an option within blocks?
…On Fri, Apr 30, 2021 at 4:40 AM Nik Tsekouras ***@***.***> wrote:
Hey 👋 - many blocks that have inner blocks (like Cover) can insert a
pattern inside. In the gif below you can see that this is possible. One
thing worths noting though is that there is a (not in depth) check that
checks if pattern's blocks are allowed based on where they are going to be
inserted. For example if we have in our settings/preferences some blocks
that are not allowed, the patterns that include those blocks are not shown
as an option. Could be that the case of the issue you're having?
[image: cover]
<https://user-images.githubusercontent.com/16275880/116684017-0ef65280-a9b9-11eb-940e-d1b7b4957782.gif>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31342 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANS32QO7SYE4MBRWBFGRVTTLKCLNANCNFSM432E3R3A>
.
|
No. The default is to show the allowed patterns where possible - there is a (not in depth) check that checks if pattern's blocks are allowed based on where they are going to be inserted. If patterns are shown in top level and are not removed by this filter for example, there should be patterns available inside other blocks as well. Of course this depends on a couple more things about what pattern is being allowed. For example in a |
The functionality for showing patterns inside a block was added here: #28459. (GB plugin v. 10.0) Maybe you have an older WP version that doesn't contain this code? |
Yeah, as noted above this functionality was implemented in GB version 10.0. Reference: https://developer.wordpress.org/block-editor/contributors/versions-in-wordpress/ I'm closing this issue as it will be resolved with the new WP version (5.8) |
If the user has a cover block, for example, and they want to add a pattern within that cover block, it is not an option.
I can understand if all blocks shouldn't allow patterns (the button block, for instance), but the cover block should at least be one exception as it would be useful to add column patterns within it.
The text was updated successfully, but these errors were encountered: