Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Panel: Add Clear option to Text and Background Color Panels #42689

Closed
paaljoachim opened this issue Jul 26, 2022 · 6 comments · Fixed by #46507
Closed

Color Panel: Add Clear option to Text and Background Color Panels #42689

paaljoachim opened this issue Jul 26, 2022 · 6 comments · Fixed by #46507
Assignees
Labels
[Feature] Colors Color management [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Jul 26, 2022

What problem does this address?

Lack of consistency.
Example from Text Color Panel in TT1 in the Side Editor. (WP 6.0 and Gutenberg plugin 13.7.2)

Color Panel: Text
Screenshot 2022-07-26 at 08 53 22

Color Panel: Link.
Screenshot 2022-07-26 at 08 53 42

The Link Panel has a Clear option while Text and Background color panels do not.

What is your proposed solution?

Add the Clear option to ALL Color panels. Inside the Site Editor and also in the Post Editor.
@jameskoster @javierarce

@paaljoachim paaljoachim added [Type] Enhancement A suggestion for improvement. [Feature] Colors Color management labels Jul 26, 2022
@richtabor
Copy link
Member

Confirmed this is still the case.

Do you think we need a "Clear" action there? I haven't noticed it missing from the background and text controls myself. Curious what others think.

@javierarce
Copy link
Contributor

Since we have a reset option in the ellipse menu that has the same effect, I think we could remove the Clear action from there.

Screenshot 2022-12-13 at 09 44 35

@paaljoachim
Copy link
Contributor Author

One method that is good to keep in place is click color to select. Click it again to deselect.
This does not work when creating a custom color.

The clear option might be a redundant, but at the same time it is also very obvious.
Reset options inside the 3 dot contexual menu feels like a good place to reset various options. As in the example that can be seen which is shared by Javier.

@richtabor
Copy link
Member

This does not work when creating a custom color.

Not quite following here. Is there a separate issue indicating this? Select/deselect should would on every color/gradient control.

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Dec 14, 2022

EDIT: NB! My mistake. Retesting in next post.

Example.
Clicking Background color. Clicking into custom color area so the transparent area is filled in with a color.
Screenshot 2022-12-14 at 09 39 18 There is no clear button.

Btw I checked again and I am not able to see the Clear button at all using Gutenberg plugin 14.7.1 and TT1 theme. As it uses the 3 dot drop down menu with the reset option.

Screenshot 2022-12-14 at 09 48 07

@paaljoachim
Copy link
Contributor Author

paaljoachim commented Dec 15, 2022

Retesting.
Gutenberg plugin 14.7.3. (The only plugin which is active.)
WordPress 6.1.1

Varies themes.
Testing environment is an online development site in the Brave browser.
Using a Heading block.


TT1.
Index template.
Added Heading block.

Added colors to Text, Background and Link.
Text color: from Theme.
Background color: from Custom.
Link color: from default.

Link color is showing a Clear button.
Screenshot 2022-12-14 at 23 02 11

Text and Background does not have a Clear button.


Twenty Twenty-Two

Index template.
Added Heading block.
Added colors to Text, Background and Link.

Link color is showing a Clear link.


Twenty Twenty Three

Index template.
Added Heading block.
Added colors to Text, Background and Link.

Link color is showing a Clear link.


After chasing my own tail for a few rounds I am now back again.
It seems natural to remove the Clear link as Javier mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Colors Color management [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants