Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Static homepage not connected to the Front Page template #56267

Closed
jameskoster opened this issue Nov 17, 2023 · 3 comments · Fixed by #56418
Closed

Site Editor: Static homepage not connected to the Front Page template #56267

jameskoster opened this issue Nov 17, 2023 · 3 comments · Fixed by #56418
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Nov 17, 2023

Discovered in #56244

The Front Page template will always resolve to display the homepage, regardless of whether reading settings dictate that it should display latest posts or a static page (see the template hierarchy for more info).

However, if you set a static homepage, and Front Page exists, the Site Editor doesn't make this connection, and even tells you that an incorrect template is used when you view and edit that page. The post editor works as expected.

Here's a video that hopefully demonstrates the issue clearly:

front.page.mp4

To reproduce:

  1. In reading settings select a static homepage
  2. In the Site editor create a Front Page template (if one doesn't already exist)
  3. Navigate to Pages > [your static homepage] and notice that Front Page isn't listed as the template in the details panel
  4. Edit [your static homepage] and notice that Front Page isn't listed as the template in the Inspector
@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Nov 17, 2023
@draganescu
Copy link
Contributor

Since the order is:

  1. I make a page, which uses the Page template
  2. I change settings, to use page at 1 to be homepage
  3. I go to Site editor and make a Front Page template
  • is the suggestion that when (3) is published the page at (1) is auto updated to use the Front Page template?

@jameskoster
Copy link
Contributor Author

Basically yes. The current site editor implementation is a bug because it doesn't accurately reflect the frontend. If you go and edit a static homepage when Front Page was created you don't see the correct template.

@youknowriad
Copy link
Contributor

I'm not entirely sure but I think this probably broke in #51477
Maybe someone can confirm by testing prior to that PR. Anyway, I'll continue trying to find a fix here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.
Projects
None yet
3 participants