Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to improve the shortcut to switch editor mode (mod+Shift+Alt+M) #5716

Closed
afercia opened this issue Mar 20, 2018 · 1 comment
Closed
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Mar 20, 2018

I'm not sure if this is by design or has already been discussed, thought to report it anyway.

Looks like mod+Shift+Alt+M works only when editable areas are not focused. Seems to me this way the shortcut is not available right in the moment users need it the most.

The easier way to reproduce is in the Code Editor mode:

  • switch to Code editor
  • click in the big textarea to focus it
  • try the shortcut Cmd (or Ctrl on Windows) +Shift+Alt+M
  • nothing happens

Same in the Visual editor

  • click on a paragraph to focus it
  • try the shortcut
  • nothing happens

Click on any empty area outside of the textarea or paragraphs etc.: it works.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Mar 20, 2018
@afercia afercia self-assigned this Apr 12, 2018
@afercia
Copy link
Contributor Author

afercia commented Apr 12, 2018

Seems to me this is similar to #5847 / #6144 and just needs the bindGlobal prop. PR incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

1 participant