Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigateRegions doesn't work from the editable blocks #5847

Closed
afercia opened this issue Mar 28, 2018 · 1 comment
Closed

navigateRegions doesn't work from the editable blocks #5847

afercia opened this issue Mar 28, 2018 · 1 comment
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Mar 28, 2018

navigateRegions is a keyboard-friendly feature that allows to navigate through the main Gutenberg areas with a keyboard shortcut. Pressing Ctrl + backtick focus is moved and cycles through the top toolbar, the editing area, and the sidebar. Shift + Ctrl + backtick cycles in the opposite direction.

Inspired by a similar feature in Slack, it has been brilliantly implemented and it's a great feature for keyboard users.

Unfortunately, seems to work only when focus is not inside an editable block, which kinda defects its purpose. At any moment, users should be able to use Ctrl + backtick to jump through the editor main sections, evne (an especially) when they're typing in an editable block.

To reproduce:

  • using the keyboard, navigate to a non-editable block e.g. an image block
  • press Ctrl + backtick and observe focus cycles through the 3 main editor sections
  • tab into a paragraph, in the text area
  • press Ctrl + backtick
  • nothing happens

Note: honestly I'm not sure if navigateRegions has ever worked from editable blocks, but it's of fundamental importance to make it work from anywhere.

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Mar 28, 2018
@afercia afercia self-assigned this Apr 12, 2018
@afercia
Copy link
Contributor Author

afercia commented Apr 12, 2018

As far as I see, all that's needed here is to use bindGlobal for the Mousetrap shortcuts. PR incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant