Template Part: using name "content" conflicts with the post content block

[dabowman]

Description

I created a pattern called "Content". I added the post content block inside of it. This results in the pattern being inserted inside itself.

Step-by-step reproduction instructions

Make new template part in the general area.
Name it Content
add the "Content" block inside of it.
You should get a "this block cannot be rendered inside itself" error.

Screenshots, screen recording, code snippet

video1577399600.mp4

Environment info

Wp 6.4
Gutenberg 17.5.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

[annezazu]

Hey David! I can't replicate this with a site using 6.4.2:

Screen.Recording.2024-01-24.at.9.59.50.AM.mov

However, I could replicate with 6.4.2 + GB 17.5.1:

Screen.Recording.2024-01-24.at.10.01.50.AM.mov

Looks like something changed since 6.4.2. Adding this to the 6.5 board as this is a regression.

[colorful-tones]

I'm digging into this one to find where the regression was introduced.

Test instructions to reproduce the issue:

1. Launch Site Editor > Patterns > Manage all template parts (at bottom) > Add New Template Part
2. Name the template part "Content" (this is not critical and seems that the naming is not an issue in this matter), and choose 'General' as the type, and click 'Create'
3. Add the Content block and note the message: 'Block cannot be rendered inside itself.' 👈 This message was not appearing before.

[colorful-tones]

Something introduced in Gutenberg 17.1.0 is where the regression is caused. I'm trying to narrow down the commit now.

[colorful-tones]

Ok, it seems that this regression was introduced in f9b544d
Pinging @youknowriad for clarity, because he worked on the associated PR #56000

[annezazu]

Thanks so much for tracking this down!