Editor: Fix block context defined for template parts #58807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
|
Size Change: +26 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @dabowman. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
Feb 8, 2024
Co-authored-by: George Mamadashvili <[email protected]>
mtias
reviewed
Feb 8, 2024
| @@ -28,6 +28,12 @@ const { ExperimentalBlockEditorProvider } = unlock( blockEditorPrivateApis ); | |||
| const { PatternsMenuItems } = unlock( editPatternsPrivateApis ); | |||
|
|
|||
| const noop = () => {}; | |||
| const NON_CONTEXTUAL_POST_TYPES = [ | |||
There was a problem hiding this comment.
Would be helpful to explain further what these are or why they are distinct
There was a problem hiding this comment.
Follow-up here #58836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #58215
Regression introduced in #56000
What?
Using Post Content blocks was causing an error within the template part editor because we were considering that the "postId" defined in the context corresponded to the same template part being rendered and obviously we can't render a template part within itself.
The problem is that we shouldn't be defining the template part's postId as the "post" context being rendered. In fact there are multiple post types who's editor shouldn't define any context: navigation, template part, reusable block and templates These are global entities that are only there to split blocks into logical units but they don't provide a "context" for the current post/page being rendered.
How?
So this PR solve the issue by not providing any "post" context when editing these entities.
Testing instructions