Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift up in first text block should select to 1st character #6164

Closed
jasmussen opened this issue Apr 13, 2018 · 3 comments · Fixed by #14453
Closed

Shift up in first text block should select to 1st character #6164

jasmussen opened this issue Apr 13, 2018 · 3 comments · Fixed by #14453
Assignees
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended
Milestone

Comments

@jasmussen
Copy link
Contributor

There's an issue with shift selecting. GIF:

shift select

Shift select across paragraphs works.

Setting the caret in the last text block and shift selecting downwards, selects until the end of the text in that block, as it should.

Setting the caret in the first block and shift selecting upwards, doesn't seem to select until the beginning of the text in that block, as would be expected.

This was a split out from #5548 (comment)

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Apr 13, 2018
@designsimply
Copy link
Member

Tested and found that setting the caret in the first block and selecting upward does not select until the beginning of the text in that block and setting the caret in the last block and selecting downward does not select until the end of the text in that block.

Video: 56s
Seen at http://alittletestblog.com/wp-admin/post.php?post=13999&action=edit running WordPress 4.9.7 and Gutenberg 3.3.0 using Firefox 61.0.1 on macOS 10.13.6.

@tofumatt tofumatt added this to the 3.6 milestone Aug 9, 2018
@youknowriad youknowriad modified the milestones: 3.6, 3.7 Aug 15, 2018
@youknowriad youknowriad removed this from the 3.7 milestone Aug 30, 2018
@earnjam earnjam added this to the WordPress 5.0.1 milestone Nov 11, 2018
@youknowriad
Copy link
Contributor

Just to confirm @aduth you were looking at this recently right? Is there a PR to link to?

@aduth
Copy link
Member

aduth commented Feb 14, 2019

Yes, see #13638 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Bug An existing feature does not function as intended
Projects
None yet
7 participants