Input Interaction: allow outer vertical edge to be selected #14453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding an e2e test in a bit. |
ellatrix
added
the
[Feature] Writing Flow
ellatrix
force-pushed
the
try/allow-selecting-vertical-edge
branch
from
5bdb6d5
to
1146ad5
Compare
ellatrix
requested review from
aduth,
ajitbohra,
gziolo,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
ellatrix
force-pushed
the
try/allow-selecting-vertical-edge
branch
from
1146ad5
to
daba7a2
Compare
|
😍✨ |
This was referenced Mar 15, 2019
Closed
This was referenced Mar 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
* Input Interaction: allow outer vertical edge to be selected * Add e2e test
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
* Input Interaction: allow outer vertical edge to be selected * Add e2e test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6164.
Currently, it is not possible to select the outer edge of a block vertically.
It's probably easier to understand by steps to reproduce:
shift+arrowUp.Expected: all text before the caret to be selected. Actual: nothing happens.
Solution: look whether there is a block before or after the current block before attempting multi-block selection. If there is none, the event should not be default prevented.
How has this been tested?
Screenshots
Types of changes
Checklist: