Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arrow navigation to the editor toolbars #631

Closed
afercia opened this issue May 3, 2017 · 2 comments
Closed

Add arrow navigation to the editor toolbars #631

afercia opened this issue May 3, 2017 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@afercia
Copy link
Contributor

afercia commented May 3, 2017 •
edited
Loading

As mentioned on #628 the editor toolbars should use arrow navigation. It should work in the same way it's going to be implemented for the inserter menu, see #515.

Tab, Down, and Right: to navigate to the next control
Shift+Tab, Up, and Left: to navigate to the previous control

Edit: actually, I'm not sure about Tab. If implemented as ARIA toolbars, there should be just arrows navigation.

Also, both tabbing and arrowing should be constrained within the toolbar.

Worth noting this it's a standard feature of the current Editor: once you focus the toolbar with Alt+F10 all the buttons can be navigated with both the Tab key and the arrow keys.
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 3, 2017
This was referenced May 3, 2017
Closed
Closed
@aduth aduth added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take labels May 26, 2017
@afercia afercia mentioned this issue Jul 21, 2017
Closed
@afercia afercia mentioned this issue Oct 11, 2017
Merged
@afercia
Copy link
Contributor Author

afercia commented Nov 6, 2017

There is now just one, fixed, toolbar at the top but this issue still applies.

@afercia afercia mentioned this issue Nov 8, 2017
Closed
@afercia
Copy link
Contributor Author

afercia commented Nov 8, 2017

Arrow navigation is now implemented. Further improvements discussed on #3383

@afercia afercia closed this as completed Nov 8, 2017
@afercia afercia mentioned this issue May 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karmatosed @afercia @aduth