Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the editor toolbar have a role=toolbar? #632

Closed
afercia opened this issue May 3, 2017 · 2 comments
Closed

Should the editor toolbar have a role=toolbar? #632

afercia opened this issue May 3, 2017 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Question Questions about the design or development of the editor.

Comments

@afercia
Copy link
Contributor

afercia commented May 3, 2017

More something to discuss with accessibility people and anyone interested, than a real technical issue. Speaking about these toolbars:

toolbar

#631 aims to provide arrow navigation, so should they also have an appropriate ARIA role?
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 3, 2017
@afercia afercia mentioned this issue May 3, 2017
Closed
@mtias mtias added [Type] Question Questions about the design or development of the editor. Design labels May 4, 2017
@afercia
Copy link
Contributor Author

afercia commented Jun 1, 2017 •
edited
Loading

This applies also to other groups of controls, for example the text editor quicktags buttons. They're a typical example of "toolbar" ad described in the WAI-ARIA Authoring Practices
https://www.w3.org/TR/wai-aria-practices/#toolbar

screen shot 2017-06-01 at 22 35 53

ideally they should be grouped in an element with role="toolbar" and implement arrow navigation (see link above)

This was referenced Jul 20, 2017
Closed
Closed
@afercia afercia mentioned this issue Aug 7, 2017
Closed
@karmatosed karmatosed removed the Design label Sep 24, 2017
@afercia afercia mentioned this issue Oct 11, 2017
Merged
@afercia afercia mentioned this issue Oct 27, 2017
Closed
2 tasks
@afercia afercia mentioned this issue Nov 8, 2017
Closed
@afercia
Copy link
Contributor Author

afercia commented Nov 8, 2017

Many things have changed: there is now just one "dynamic" fixed toolbar at the top. Further improvements and discussion on interaction and ARIA roles are now being discussed on #3383

@afercia afercia closed this as completed Nov 8, 2017
@afercia afercia mentioned this issue May 1, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Apr 15, 2020
Open
@snyk-bot snyk-bot mentioned this issue Sep 12, 2020
Open
@snyk-bot snyk-bot mentioned this issue Jun 6, 2021
Open
@snyk-bot snyk-bot mentioned this issue Sep 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Question Questions about the design or development of the editor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karmatosed @mtias @afercia