Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move paragraph alignment to toolbar #6476

Closed
karmatosed opened this issue Apr 28, 2018 · 3 comments
Closed

Move paragraph alignment to toolbar #6476

karmatosed opened this issue Apr 28, 2018 · 3 comments
Assignees
Labels
[Type] Enhancement A suggestion for improvement.
Milestone

Comments

@karmatosed
Copy link
Member

We now have the alignment just in one place on the paragraph block, which is great.

alignp

The problem though is all other blocks have this by the toolbar. Let's bring this back to the toolbar and remove from the sidebar please. Like image for example has:

aligni

@karmatosed karmatosed added the [Type] Enhancement A suggestion for improvement. label Apr 28, 2018
@karmatosed karmatosed added this to the Merge Proposal: Editor milestone Apr 28, 2018
@youknowriad
Copy link
Contributor

I believe the block alignment toolbar is also shown in the inspector for quote blocks. I think the idea was to avoid two alignment toolbars at the same time in the toolbar (text alignment and block alignment), happy to update with what you think is best.

@karmatosed
Copy link
Member Author

karmatosed commented Apr 30, 2018

@youknowriad that's a very valid point and one I'm going backwards and forward on right now. We have an issue where consistency is a huge issue for people and moving alignment options adds to that. I feel in this case unifying makes sense by having all in toolbar. Probably sensible to pick up quote blocks too.

@jasmussen
Copy link
Contributor

I think we should remove the block alignment toolbar from paragraphs altogether, as I feel like these should be reserved for a container block. So you select the container to choose the layout, and you can then choose individual paragraphs inside to change the text alignment.

This would work for quotes as well, as quotes are destined to become container blocks for nested paragraphs regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants