Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Color Picker styling issues #6750

Closed
yuanworks opened this issue May 15, 2018 · 6 comments
Closed

Chrome Color Picker styling issues #6750

yuanworks opened this issue May 15, 2018 · 6 comments
Labels
[Feature] Document Settings Document settings experience [Type] Bug An existing feature does not function as intended

Comments

@yuanworks
Copy link

The popup color picker (aka. Chrome Picker) has CSS styling issues.

Steps To Reproduce

  1. Go to a new Paragraph Block
  2. Select the background / font color
  3. Choose a custom color

Issues

  1. Width of the Chrome Picker is not the same as the parent popup component.
  2. ChromePicker is using "Menlo" font by default, which is defaulting to a sans-serif font on Windows (ideally should just use the font-family: inherited which doesn't break the layout)

Screenshot
image

Desktop (please complete the following information):

  • OS: Mac, Windows
  • Browser Chrome, Firefox

Smartphone (please complete the following information):

  • Device: Android

If there's a green light on this, I will work on a PR for it.

@ajitbohra
Copy link
Member

ajitbohra commented May 15, 2018

styling issues have been fixed in the master branch

#5962 (comment)

@danielbachhuber danielbachhuber added [Type] Bug An existing feature does not function as intended [Feature] Document Settings Document settings experience labels May 16, 2018
@danielbachhuber
Copy link
Member

@yuanworks Can you create a pull request for issue 2?

ChromePicker is using "Menlo" font by default, which is defaulting to a sans-serif font on Windows (ideally should just use the font-family: inherited which doesn't break the layout)

@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone May 16, 2018
@yuanworks
Copy link
Author

yuanworks commented May 21, 2018

@ajitbohra for some reason I still see the wrong picker width after pulling from master on localhost, on the just-released 2.9.1 on a test site, as well as on https://testgutenberg.com/ (I'm aware that's running 2.8, but this issue seems to have been fixed some time ago).

Am I missing some other step after git pull origin? (other than npm install / npm run dev)

@pento
Copy link
Member

pento commented May 21, 2018

@yuanworks: I can reproduce the same bug locally, #5962 was closed without being merged, so it hasn't actually been fixed.

@yuanworks
Copy link
Author

yuanworks commented May 22, 2018

Thanks @pento. Regarding the second issue I noted, Menlo is I believe a strictly MacOS font, and on Windows seeing the default serif Times New Roman font is an eyesore; it doesn't have as quick of a fix as the width though.

image

Should I try to contact the author of the component (not sure if Gutenberg is always keeping up with their latest version) so that he can hard-code something like font-famiy: Menlo, sans-serif to the component or it's better just to wait and see if the component will be rebuilt?

@pento
Copy link
Member

pento commented May 22, 2018

Hrrm, that's a problem. It's worth contacting the author, but as @mtias suggested in #6863, we may need to rebuilt the colour picker, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Document Settings Document settings experience [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants