Set the correct min-width for the ChromePicker popover #6863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pento
added
[Type] Bug
gziolo
approved these changes
May 21, 2018
|
This is fine, we still need to evaluate if we go with this picker or rebuilt it ourselves (from its primitives). There were accessibility issues as it stands. |
karmatosed
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #6750, by overriding the
min-widthof the popover container of the ChromePicker widget.This special case is required, as ChromePicker hardcodes it's width, with no apparent option for overriding it.
Note: #5962 suggested an alternate method for fixing this, but it appears that's how it was originally implemented, but it caused other problems, so was removed in #3120.
Screenshots
Before
After
Checklist: