Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tweaking nested block side action styles #7182

Closed
chrisvanpatten opened this issue Jun 6, 2018 · 2 comments
Closed

Consider tweaking nested block side action styles #7182

chrisvanpatten opened this issue Jun 6, 2018 · 2 comments
Labels
[Type] Enhancement A suggestion for improvement.

Comments

@chrisvanpatten
Copy link
Member

chrisvanpatten commented Jun 6, 2018

To make it easier to tell which side tools are visible, the side tools for nested blocks (inside innerblocks layout areas) have a slightly different style; currently like this, with visible button borders:

untitled___ mindful_org _wordpress

This is slightly different from parent blocks, which don't display borders:

untitled___ mindful_org _wordpress

The distinction is helpful but I think can be improved — and make the side UI a little more consistent with the main toolbar — by wrapping these areas in a border instead of an always-visible border for individual styles.

Before and after:

block-side-tools

And here's a demo:

kapture 2018-06-06 at 11 35 35

This could extend to parent blocks as well, for greater consistency, although I didn't include that in the above demo.

Note that I also styled the borders to match the block hover styles implemented in #6773 but that could be changed as well.

@chrisvanpatten
Copy link
Member Author

I've posted a PR for this in #7211. It's far from merge-able, but is useful as a way to try it out locally and get a feel for the change in your own environment. Would love thoughts and design feedback!

@ajitbohra ajitbohra added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Jul 8, 2018
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Jul 15, 2018
@karmatosed
Copy link
Member

Closing this as we've explored other options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants