-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The ChromePicker (Custom color picker) is not accessible #7246
Comments
For reference, here's how accessible sliders should be implemented: |
What's the alternative? |
I think the best person who can answer your question is @mtias as he worked on Iris and he certainly knows better than me if it can be easily react-ified 🙂 |
@grahamarmfield that's exactly what @afercia also suggested on his previous comment |
I was looking into this today, and while we could contribute back to I think it would be a better approach to fork the |
The improvements made in #10564 dramatically increase the accessibility of the colour picker, so I'm going to close this issues as it relates to the near-unusable state of the original colour picker (it was really difficult to use with a screenreader and/or keyboard). I've filed #10975 as follow-up issue to address some points made in #10564. Closing this one as fixed though; we should iterate in #10975. |
The
ChromePicker
provided byreact-color
has accessibility issues that make it almost unusable for keyboard users and screen reader users.A few months ago, this was quickly discussed on Slack. At that time, the chrome picker wasn't considered "stable" so it wasn't the right time to pay attention to it.
Re:
react-color
see also #2383:/Cc @mtias
By the way, I see there's now a pending PR to add an alpha transparency UI control to the chrome picker, so I have the impression the current plan is to keep this component?
If so, I'd strongly recommend to reconsider the plan as
ChromePicker
doesn't meet the accessibility and quality standards Gutenberg aims to implement.Main issues identified so far:
On the other hand, I'd like to remind the WordPress color picker based on Iris is way better with regards to accessibility and it would need just some minor improvements.
Screenshots with Safari and VoiceOver:
The text was updated successfully, but these errors were encountered: