Report error when URLs can't be embedded and don't generate a fallback #10407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
approved these changes
Oct 10, 2018
There was a problem hiding this comment.
This looks good and works a charm!
The only nitpick I'd have is that there a mixing of types (preview can be a boolean or an object, cannotEmbed can be a string or a boolean), which could cause some issues down the line if someone else tries to use those variables thinking they're one type when they're another. I think we've had this bite us when trying to optionally set attributes on elements.
aduth
reviewed
Oct 10, 2018
| @@ -412,8 +414,12 @@ function getEmbedBlockSettings( { title, description, icon, category = 'embed', | |||
| const preview = url && getEmbedPreview( url ); | |||
| const previewIsFallback = url && isPreviewEmbedFallback( url ); | |||
| const fetching = undefined !== url && isRequestingEmbedPreview( url ); | |||
| // Some WordPress URLs that can't be embedded will cause the API to return | |||
There was a problem hiding this comment.
Should this be normalized at the REST API / data store, rather than delegating the responsibility to the consuming UI component to handle ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to embed some WordPress URLs that can't be embedded will result in a blank preview, rather than an error saying that the URL couldn't be embedded.
This is because oEmbed sometimes doesn't do
maybe_make_linkand returns a response with adata.statusof 404 instead.This change accounts for that.
How has this been tested?
Try to embed https://wordpress.org/gutenberg/handbook/
You should see the error saying that it can't be embedded.
Types of changes
Bug fix