Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser/do dynamic blocks with inner blocks #11227

Closed
wants to merge 16 commits into from
Closed

Parser/do dynamic blocks with inner blocks #11227

wants to merge 16 commits into from

Conversation

georgestephanis
Copy link
Contributor

@georgestephanis georgestephanis commented Oct 29, 2018 •
edited
Loading

Description

Let dynamic blocks contain inner blocks.

Depends on #11141 and #11082 in turn.

How has this been tested?

Unit Tests and testing against relevant nested dynamic blocks in Jetpack Contact Form.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.
  • N/A -- My code follows the accessibility standards.

@georgestephanis georgestephanis mentioned this pull request Oct 29, 2018
Merged
@dmsnell dmsnell force-pushed the parser/do-blocks-with-full-parse branch 7 times, most recently from 8e2e243 to 7309d7f Compare November 10, 2018 02:17
@mtias
Copy link
Member

mtias commented Nov 12, 2018

Closing as merged in #11141.

@mtias mtias closed this Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgestephanis @mtias @dmsnell