Allow custom style in dashicon/svg #12403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koke
added
the
Mobile App - i.e. Android or iOS
This was referenced Nov 28, 2018
koke
added a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Nov 29, 2018
We're skipping WordPress/gutenberg#12403 for now
pinarol
pushed a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Nov 30, 2018
* Make the inline toolbar nicer This replaces the icons with dashicons, tweaks the layout to be closer to the designs, and removes the unused settings button. * Only show arrow buttons when you can move the block * Add borders to block when focused * Updated colors for inline toolbar and block holder This imports a color palette taken from calypso instead of the Gutenberg one * Remove unused imports * Revert gutenberg We're skipping WordPress/gutenberg#12403 for now * Replace InlineToolbarButton as ToolbarButton * Update subrepo ref to point to rnmobile/dashicon-styles * Update react-native-aztec to point to master * Fixed inline toolbar buttons, used to ToolbarButton interface from components * Update gutenberg subrepo ref to point to master * Fix lint issues
aduth
reviewed
Dec 3, 2018
| @@ -22,7 +22,8 @@ export default class Dashicon extends Component { | |||
| this.props.icon !== nextProps.icon || | |||
| this.props.size !== nextProps.size || | |||
| this.props.className !== nextProps.className || | |||
| this.props.ariaPressed !== nextProps.ariaPressed | |||
| this.props.ariaPressed !== nextProps.ariaPressed || | |||
| this.props.style !== nextProps.style | |||
There was a problem hiding this comment.
This file is generated by the Dashicons project and copied here verbatim. The files should not be manually revised without an upstream patch.
|
Closing, since we found a way around it that doesn't require to modify dashicons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the previous solution in #11827 by allowing a
styleprop to be passed to aDashicon.The previous solution required
Svgbeing aware of other parts of the app and including hardcoded colors in its CSS.This change lets you override those and specify the style directly. I haven't changed the existing toolbar icons since
IconButtonwill pass the extra props toButton, notDashiconTo be tested with wordpress-mobile/gutenberg-mobile#286 for the inline toolbar buttons