Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 11669 make block icon accessible #12553

Conversation

timwright12
Copy link
Contributor

@timwright12 timwright12 commented Dec 3, 2018

Description

null

How has this been tested?

  • Linting
  • Browser testing
  • Local e2e
  • Local Unit

Types of changes

Converted disabled block icon buttons to a span so can can be semantically presentational and removed from assistive technology.

Checklist:

  • [ x ] My code is tested.
  • [ x ] My code follows the WordPress code style.
  • [ x ] My code follows the accessibility standards.
  • [ x ] My code has proper inline documentation.

@timwright12 timwright12 closed this Dec 3, 2018
@timwright12 timwright12 deleted the fix/issue-11669-make-block-icon-accessible branch December 3, 2018 16:42
@timwright12
Copy link
Contributor Author

pulling this back for a bit, I had an extra file sneak in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant