Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Restore block mover for floats. #12758

Merged
merged 3 commits into from
Feb 6, 2019
Merged

Try: Restore block mover for floats. #12758

merged 3 commits into from
Feb 6, 2019

Commits on Feb 5, 2019

  1. Try: Restore block mover for floats.

    This PR hopes to fix #12736, #11424, #10300.
    
    Currently we hide the block mover for any floated block. We do this because if you have a left floated image followed by a paragraph, the block mover for the image would overlap exactly with the block mover for the subsequent paragraph block. This would cause moving a float to be fiddly and virtually impossible as the hover states for the two conflicted.
    
    This PR is an experiment to mitigate, or possibly fix that. It's a try branch because it is not necessarily a solid fix. What this PR does:
    
    - It makes it so the block mover cannot be invoked when only hovering a float, but when the float is selected they are permanently visible.
    - It changes some z-indexes so floats always have a higher z-index than not a float.
    - It changes the footprint of the side-UI container to "cover up" the underlying paragraph block, so it won't invoke unlesss you move the mouse below the footprint.
    
    This is best explained in some GIFs.
    
    The reason this is a "Try" branch is that when you move the mouse over the adjacent paragraph, the block mover is show as overlapping the selected floats block mover. But due to the rearranging of z-indexes, at least this is only a visual issue. A click on the floats block mover will still work as intended.
    
    Why can't the float have on-hover block movers like every other block, you ask? Picture again the test-case of a left floated image followed by a paragraph of text. In this case, hovering over the image would show a block mover that would visually appear to be that of the paragraph block. By showing it when the float is selected, the context is clear.
    
    We could experiment with not showing the hover block mover for float-adjacent blocks when hovered, but this isn't feasible because you might have a float, and then a block that clears this float, in which case the rule would break down.
    
    Lay your thoughts on me.
    Joen Asmussen committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    d7f155e View commit details
    Browse the repository at this point in the history
  2. Address feedback, and improve dragging edgecase.

    This addresses comment feedback by @ZebulanStanphill, thanks, and it also hides the block mover from the ghost when you are dragging.
    Joen Asmussen committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    f45ae27 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Add borders around floats.

    Joen Asmussen committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    bf6d1f3 View commit details
    Browse the repository at this point in the history