-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Extract e2e test utils to their own package #13228
Conversation
packages/e2e-tests/specs/blocks/__snapshots__/quote.test.js.snap
Outdated
Show resolved
Hide resolved
packages/e2e-tests/specs/plugins/__snapshots__/meta-attribute-block.test.js.snap
Outdated
Show resolved
Hide resolved
b46710f
to
1edf9e8
Compare
@youknowriad - I haven't found a good way to run those tests from withing
|
@gwwar @Copons - not sure if you are still looking into increasing code reuse from core for your e2e tests setup, but this PR tries to expose all test utils as a npm package. We exposed npm scripts which runs the e2e tests setup in one of the previous PRs. Once this code is published to npm, it should be easier to replicate a similar testing workflow. |
@ryelle and @greatislander - we are close to having all parts of Gutenberg's setup exposed to npm. It may take a few more days (hopefully not weeks) to have it sorted out. It should drastically simplify the way you can use it outside of Gutenberg. I'm going to work on having tooling for a11y included in this setup as my next task. |
1edf9e8
to
deed0e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, we were not able to execute a single end to end test case (e.g.: executing: npm run test-e2e packages/e2e-tests/specs/sidebar.test.js
) this PR fixes that. Although I don't have deep knowledge of the changes they make sense to me 👍
* Tests: Move e2e tests dependent on plugins to their own folder * Tests: Extract e2e test utils to their own package
* Tests: Move e2e tests dependent on plugins to their own folder * Tests: Extract e2e test utils to their own package
Description
Part of #12313.
I did some final tweaks for the code organization related to e2e tests:
@wordpress/e2e-test-utils
;@wordpress/tests-e2e
to@wordpress/e2e-tests
to align with the newly extracted package name.specs/plugins/
.How has this been tested?
npm run test-e2e
or
./node_modules/.bin/wp-scripts test-e2e --config ./packages/e2e-tests/jest.config.js