Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flags for Phase 2 #13324

Merged
merged 22 commits into from
Feb 15, 2019
Merged

Add feature flags for Phase 2 #13324

merged 22 commits into from
Feb 15, 2019

Commits on Feb 15, 2019

  1. Add new package for editor configuration, initially containing just f… 

    …eature flags

Rework build commands to use correct NODE_ENV for feature flags
    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    fb60a6c View commit details
    Browse the repository at this point in the history

  2. Revert "Rework build commands to use correct NODE_ENV for feature flags" 

    This reverts commit 4cb0a39.

Revert "Add new package for editor configuration, initially containing just feature flags"

This reverts commit 0c21fc2.
    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    3215406 View commit details
    Browse the repository at this point in the history

  3. Switch to using webpack define plugin to inject a global GUTENBERG_PH… 

    …ASE variable
    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    a8a3494 View commit details
    Browse the repository at this point in the history

  4. Iterate: use window.GUTENBERG_PHASE to avoid thrown errors from an un… 

    …defined global
    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    4d8f8f9 View commit details
    Browse the repository at this point in the history

  5. Add custom eslint rule for usage of GUTENBERG_PHASE

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    116be55 View commit details
    Browse the repository at this point in the history

  6. Disable new eslint rule when used in webpack config

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    2116715 View commit details
    Browse the repository at this point in the history

  7. Add readme

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    c678413 View commit details
    Browse the repository at this point in the history

  8. Include phase 2 features in e2e tests

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    fb9768d View commit details
    Browse the repository at this point in the history

  9. Allow use of GUTENBERG_PHASE in a ternary and update documentation.

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    73f13dc View commit details
    Browse the repository at this point in the history

  10. Add links to docs

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    f395860 View commit details
    Browse the repository at this point in the history

  11. Minor docs changes

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    4be7f07 View commit details
    Browse the repository at this point in the history

  12. Switch from window.GUTENBERG_PHASE to process.env.GUTENBERG_PHASE

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    ada6f4c View commit details
    Browse the repository at this point in the history

  13. Update docs for feature flags. Move Basic Use section higher up, an… 

    …d simplify a sentence
    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    ddce9f7 View commit details
    Browse the repository at this point in the history

  14. Ensure GUTENBERG_PHASE environment variable is available for webpack

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    e91a027 View commit details
    Browse the repository at this point in the history

  15. Ensure GUTENBERG_PHASE is a number

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    7edd5c5 View commit details
    Browse the repository at this point in the history

  16. Ensure GUTENBERG_PHASE is set in unit tests

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    6c93c7b View commit details
    Browse the repository at this point in the history

  17. Use <rootDir> in jest config

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    806cdb8 View commit details
    Browse the repository at this point in the history

  18. switch to using package.json config to define the value of GUTENBERG_… 

    …PHASE
    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    235a770 View commit details
    Browse the repository at this point in the history

  19. Sort custom lint rules alphabetically

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    ddc3853 View commit details
    Browse the repository at this point in the history

  20. Add comment about GUTENBERG_PHASE

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    94ffc01 View commit details
    Browse the repository at this point in the history

  21. Update jest config for GUTENBERG_PHASE

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    c78d6b4 View commit details
    Browse the repository at this point in the history

  22. Add webpack as dependency to main package.json

    @talldan
    talldan committed Feb 15, 2019
    Configuration menu
    Copy the full SHA
    57731f5 View commit details
    Browse the repository at this point in the history