-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Make placeholder text working on RichText #13699
Merged
hypest
merged 3 commits into
master
from
rnmobile/make-placeholder-text-working-on-richtext-mobile
Feb 7, 2019
Merged
[RNMobile] Make placeholder text working on RichText #13699
hypest
merged 3 commits into
master
from
rnmobile/make-placeholder-text-working-on-richtext-mobile
Feb 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniloercoli
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Feb 6, 2019
As per chat convo I removed the |
hypest
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
hypest
deleted the
rnmobile/make-placeholder-text-working-on-richtext-mobile
branch
February 7, 2019 11:52
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Make placeholder text working again on RichText * Make sure the native side is always refreshed when the RichText component is cleared * Remove placeholder check
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Make placeholder text working again on RichText * Make sure the native side is always refreshed when the RichText component is cleared * Remove placeholder check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does fix an issue where the
placeholder
text wasn't working fie onRichText
for mobile.The issue was noticed and reported since the Title block is now using the RichText component, but the problem was there on other blocks already. See Para and Heading.
Not sure when we broke it, but i guess long time ago.
Now the placeholder is visible on Para/Heading/Title blocks.
GB-mobile side PR is here: wordpress-mobile/gutenberg-mobile#544