Mobile - Remove unnecessary forceUpdate #13705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
the
Mobile App - i.e. Android or iOS
pinarol
changed the title
pinarol
changed the title
etoledom
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Working good!
Tested on wordpress-mobile/gutenberg-mobile#554
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Remove force update on content size change * Remove setting minHeight since it is already set in paragraph and heading
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Remove force update on content size change * Remove setting minHeight since it is already set in paragraph and heading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To Fix: wordpress-mobile/gutenberg-mobile#583
We can remove the old forceUpdate here since it is not necessary and it might be causing unnecessary re-rendering that we don't want.
How has this been tested?
Tested with mobile-gutenberg PR.
Checklist: