Mobile: Fix BottomSheet TextInput Cell alignment issue for RTL layout. #13815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etoledom
added
the
Mobile App - i.e. Android or iOS
|
Thank you! |
4 tasks
This was referenced Feb 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
#13815) * Fix BottomSheet TextInput Cell alignment issue in RTL layout. * Fix lint issues
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
#13815) * Fix BottomSheet TextInput Cell alignment issue in RTL layout. * Fix lint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue related to RTL layout on the BottomSheet cell.
This was an issue since we are inverting the natural alignment for text inputs, so we had to express this intention on RTL layout too. Sadly
text-align: enddidn't work (it's not allowed).To test:
Refer to the related
gutenberg-mobilePR.