Move the reusable blocks buttons to the editor module #14387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
mkaz,
noisysocks,
oandregal,
notnownikki and
talldan
as code owners
youknowriad
changed the title
youknowriad
force-pushed
the
update/move-reusable-block-buttons-to-editor
branch
from
f35ad70
to
e28c708
Compare
This was referenced Mar 21, 2019
aduth
approved these changes
Mar 25, 2019
packages/editor/src/components/reusable-blocks-buttons/index.js
Outdated
Show resolved
Hide resolved
| <_BlockSettingsMenuPluginsExtension.Slot fillProps={ { clientIds, onClose } } /> | ||
| <div className="editor-block-settings-menu__separator block-editor-block-settings-menu__separator" /> | ||
| { count === 1 && ( |
There was a problem hiding this comment.
I guess with this change, "Remove from Reusable Blocks" is moved to before the horizontal line in the menu, ungrouped from Remove Block. I don't see it being much an issue (grouped with reusable convert button vs. grouped with remove block button), but worth pointing out.
| Before | After |
|---|---|
 |
 |
| * | ||
| * @param {Object} state Editor state. | ||
| * | ||
| * @return {Array} Multi-selected block client IDs. | ||
| */ | ||
| export const getMultiSelectedBlockClientIds = createSelector( | ||
| export const getSelectedBlockClientIds = createSelector( |
There was a problem hiding this comment.
Could do for some separate unit tests to distinguish the two functions.
Aside: This selector function confuses me as to what its doing with the slices and root traversal below.
aduth
added
[Feature] Synced Patterns
|
Needs a rebase. Might be fair to add "Performance" label, if you think it qualifies to help for future filtering reference. |
youknowriad
force-pushed
the
update/move-reusable-block-buttons-to-editor
branch
from
d6bfd8c
to
1ffcefc
Compare
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #14043
This PR moves the reusable blocks related components (buttons) to the editor module. It leverages the fact that we can extend the block settings menu using a slot.
It also includes a new selector
getSelectedBlockClientIdswhich was needed in a few other places too (it fixes some rerenderings as we were regenerating a new array in several withSelect callbakcs)The main goal of this PR is to avoid relying on
core/editorin the block editor module. We still have three remaining usage of this store there that should be handled in separate PRs.Testing instructions