Input Interaction: always expand single line selection vertically #14487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
aduth,
gziolo,
oandregal and
youknowriad
as code owners
ellatrix
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
ellatrix
added
the
[Feature] Writing Flow
oandregal
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
Works fine!
I've investigated a bit how others behave and this is what I've learned. Leaving it here for context:
- The standard doesn't mention anything about upward/downward. When it mentions forward/backward direction it says that behavior is platform-specific.
- Gutenberg selection of multiline works this way (arrowup goes upward a line, arrowdown goes downward a line). Also desktop editors behave this way.
- Some websites behave this way, others work as the former behavior (direction is taken into account). Even the same website may behave differently depending on the component (compare Github comment box VS Github review box).
All things considered, this change makes sense to me.
|
Thanks, @nosolosw! |
This was referenced Apr 1, 2019
ellatrix
added a commit
that referenced
this pull request
Apr 3, 2019
…4487) * Input Interaction: always expand single line selection vertically * Add e2e test
ellatrix
added a commit
that referenced
this pull request
Apr 4, 2019
* RichText: improve format boundary style (#14519) * RichText: improve format boundary style * rgb => rgba * Paste: check plain text for gutenberg content (#14536) * Make ClipboardButton inside a block work correctly in Safari (#7106) * Make ClipboardButton inside a block work in Safari * Update changelogs * Block Editor: Update "Next" to "Unreleased" per guidelines https://github.com/WordPress/gutenberg/blob/master/packages/README.md#maintaining-changelogs * Input Interaction: always expand single line selection vertically (#14487) * Input Interaction: always expand single line selection vertically * Add e2e test * Use MenuItem instead of IconButton (#14569) * Remove id, infoid, label and aria-describedby from MenuItem (#14423) * Preformatted: save line breaks as characters (#14653) * Preformatted: save line breaks as characters * Update e2e test * Remove negative toolbar position rules from full-aligned blocks. (#14669) * Fix issue with double scrollbar in Fullscreen Mode (#14677) This PR fixes an issue where the sidebar would have two scrollbars when in fullscreen mode. * Fix WordPress embed block resolution (#14658) * Retry failing embeds with trailing slash (#14705) * Fix embedding Twitter URLs with a trailing slash (Closes #12664) * Fix race condition for WordPress URLs that end in slashes, add test * API Fetch: Fix error on empty OPTIONS preload data (#14714) * Input Interaction: better horizontal edge detection (#14462) * Input Interaction: better horizontal edge detection * Correct BR ranges * Add e2e test * Increase buffer for Firefox * Clean up * Merge isEdge logic * Fix typo * Address feedback * Build docs * Fix memize option key typo (#14750) * RichText: unify active formats, 'selectedFormat' and 'placeholderFormat' (#14411) * RichText: unify active formats, 'selectedFormat' and 'placeholderFormat' * Add extra e2e test * Only should boundary style when focused * Update docs * Try to trigger tests with Travis * Restore Travis config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14463. When having a selection that spans over one single line, shift + vertical arrow should always expand the (block) selection, regardless of the direction of the selection.
I'll see if I can make an e2e test for it.Done.How has this been tested?
Screenshots
Types of changes
Checklist: